a869f77070
Merges feat/agent-project-membership (task 166/152). An agent can finally join many projects: membership routes, per-membership role and optional brain override, chat resolving context from the membership, and CLI attach-agent / detach-agent / get memberships. The legacy Agent.projectId fallback is kept for this release as the schema comment promises. Conflict resolved in main.ts: that branch added its RBAC case to mapUrlToPermission inline, while this branch had extracted the function to middleware/url-permission.ts so it could be tested. Kept the extraction and ported the case into it — joining a team is `edit:agents:<name>`, not `create:agents`, which is the authority to mint a whole agent. Also fixes something the extraction makes possible. security.test.ts contained a hand-copied reproduction of mapUrlToPermission, because main.ts self-invokes main() and nothing in it was importable. A security test asserting against a copy stops testing the system the moment the real one changes, and this copy had already drifted. It now imports the real function; all 18 assertions still pass, against the code that actually runs. Local: build clean, workspace 2550 passed, lint unchanged at 794 errors. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N4wNHWf7xSwnZCWpJcyv9p
26 lines
988 B
Markdown
26 lines
988 B
Markdown
# Task ID: 132
|
|
|
|
**Title:** CodeRepo repository and service layers
|
|
|
|
**Status:** pending
|
|
|
|
**Dependencies:** 119
|
|
|
|
**Priority:** medium
|
|
|
|
**Description:** Create CodeRepoRepository and CodeRepoService with credential resolution through SecretService
|
|
|
|
**Details:**
|
|
|
|
Create src/mcpd/src/repositories/code-repo.repository.ts and src/mcpd/src/services/code-repo.service.ts:
|
|
1. Repository: standard CRUD, findByProjectId
|
|
2. Service.create(): validate project exists, validate credSecretId/Key if provided
|
|
3. Service.resolveCredentials(repoId): fetch Secret via SecretService, extract the key, return credential (never store plaintext)
|
|
4. Service.update(): validate changes
|
|
5. Service.delete(): check no active sessions reference this repo
|
|
6. Follow existing service patterns for validation
|
|
|
|
**Test Strategy:**
|
|
|
|
Unit tests: test create with valid project, test credential resolution returns correct value, test create fails with invalid secret reference, test findByProjectId returns filtered list.
|