a869f77070
Merges feat/agent-project-membership (task 166/152). An agent can finally join many projects: membership routes, per-membership role and optional brain override, chat resolving context from the membership, and CLI attach-agent / detach-agent / get memberships. The legacy Agent.projectId fallback is kept for this release as the schema comment promises. Conflict resolved in main.ts: that branch added its RBAC case to mapUrlToPermission inline, while this branch had extracted the function to middleware/url-permission.ts so it could be tested. Kept the extraction and ported the case into it — joining a team is `edit:agents:<name>`, not `create:agents`, which is the authority to mint a whole agent. Also fixes something the extraction makes possible. security.test.ts contained a hand-copied reproduction of mapUrlToPermission, because main.ts self-invokes main() and nothing in it was importable. A security test asserting against a copy stops testing the system the moment the real one changes, and this copy had already drifted. It now imports the real function; all 18 assertions still pass, against the code that actually runs. Local: build clean, workspace 2550 passed, lint unchanged at 794 errors. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N4wNHWf7xSwnZCWpJcyv9p
68 lines
2.1 KiB
Markdown
68 lines
2.1 KiB
Markdown
# Task ID: 56
|
|
|
|
**Title:** Implement prompt link resolution service
|
|
|
|
**Status:** done
|
|
|
|
**Dependencies:** 40 ✓
|
|
|
|
**Priority:** medium
|
|
|
|
**Description:** Create a service that fetches linked prompt content from source MCP servers using the project's service account, with dead link detection.
|
|
|
|
**Details:**
|
|
|
|
1. Create `/src/mcplocal/src/services/link-resolver.service.ts`:
|
|
```typescript
|
|
export class LinkResolverService {
|
|
constructor(private mcpdClient: McpdClient) {}
|
|
|
|
async resolveLink(linkTarget: string): Promise<{
|
|
content: string | null;
|
|
status: 'alive' | 'dead' | 'unknown';
|
|
error?: string;
|
|
}> {
|
|
// Parse linkTarget: project/server:resource-uri
|
|
const { project, server, uri } = this.parseLink(linkTarget);
|
|
|
|
try {
|
|
// Use service account for source project
|
|
const content = await this.fetchResource(project, server, uri);
|
|
return { content, status: 'alive' };
|
|
} catch (error) {
|
|
this.logDeadLink(linkTarget, error);
|
|
return {
|
|
content: null,
|
|
status: 'dead',
|
|
error: error.message
|
|
};
|
|
}
|
|
}
|
|
|
|
private parseLink(linkTarget: string): { project: string; server: string; uri: string } {
|
|
const match = linkTarget.match(/^([^/]+)\/([^:]+):(.+)$/);
|
|
if (!match) throw new Error('Invalid link format');
|
|
return { project: match[1], server: match[2], uri: match[3] };
|
|
}
|
|
|
|
private async fetchResource(project: string, server: string, uri: string): Promise<string> {
|
|
// Call mcpd to fetch resource via service account
|
|
// mcpd routes to the source project's MCP server
|
|
}
|
|
}
|
|
```
|
|
|
|
2. Log dead links as errors
|
|
|
|
3. Cache resolution results
|
|
|
|
**Test Strategy:**
|
|
|
|
- Unit test: Valid link parsed correctly
|
|
- Unit test: Invalid link format throws error
|
|
- Unit test: Successful resolution returns content and status='alive'
|
|
- Unit test: Failed resolution returns status='dead' with error
|
|
- Unit test: Dead link logged as error
|
|
- Unit test: Service account header included in request
|
|
- Integration test: End-to-end link resolution
|