Files
mcpctl/.taskmaster/tasks/task_036.md
Michal a869f77070 merge: AgentProject membership — the junction is now load-bearing
Merges feat/agent-project-membership (task 166/152). An agent can finally join
many projects: membership routes, per-membership role and optional brain
override, chat resolving context from the membership, and CLI attach-agent /
detach-agent / get memberships. The legacy Agent.projectId fallback is kept for
this release as the schema comment promises.

Conflict resolved in main.ts: that branch added its RBAC case to
mapUrlToPermission inline, while this branch had extracted the function to
middleware/url-permission.ts so it could be tested. Kept the extraction and
ported the case into it — joining a team is `edit:agents:<name>`, not
`create:agents`, which is the authority to mint a whole agent.

Also fixes something the extraction makes possible. security.test.ts contained a
hand-copied reproduction of mapUrlToPermission, because main.ts self-invokes
main() and nothing in it was importable. A security test asserting against a
copy stops testing the system the moment the real one changes, and this copy had
already drifted. It now imports the real function; all 18 assertions still pass,
against the code that actually runs.

Local: build clean, workspace 2550 passed, lint unchanged at 794 errors.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N4wNHWf7xSwnZCWpJcyv9p
2026-08-09 23:34:18 +01:00

1.9 KiB

Task ID: 36

Title: End-to-end integration testing

Status: done

Dependencies: 29 ✓, 33 ✓, 34 ✓, 35 ✓

Priority: high

Description: Create comprehensive integration tests that validate the full data flow from mcpctl through mcplocal to mcpd to MCP server containers and back.

Details:

  1. Create test fixtures in src/mcplocal/test/fixtures/:
    • Mock MCP server that returns predictable responses
    • Test configuration files
    • Sample tool call payloads
  2. Create integration test suite in src/mcplocal/test/integration/:
    describe('End-to-end flow', () => {
      it('mcpctl -> mcplocal -> mcpd -> mcp_server', async () => {
        // Start mock MCP server
        // Start mcpd with test config
        // Start mcplocal pointing to mcpd
        // Execute mcpctl command
        // Verify response flows back correctly
      });
    
      it('LLM pre-processing reduces response size', async () => {
        // Send query that returns large dataset
        // Verify LLM filtering reduces token count
        // Verify relevant data is preserved
      });
    
      it('credentials never leave mcpd', async () => {
        // Monitor all traffic from mcplocal
        // Verify no credentials appear in requests/responses
      });
    });
    
  3. Test scenarios:
    • Management commands (get servers, instances, etc.)
    • MCP tool calls with LLM preprocessing
    • MCP tool calls without preprocessing
    • Error handling (mcpd down, instance down, LLM failure)
    • Health monitoring accuracy
  4. Add CI integration test workflow
  5. Create docker-compose.test.yml for test environment

Test Strategy:

  1. All integration tests pass in CI environment
  2. Test coverage includes happy path and error scenarios
  3. Performance benchmarks: measure latency at each tier
  4. Security test: verify credential isolation
  5. Load test: multiple concurrent requests
  6. Chaos test: random component failures