a869f77070
Merges feat/agent-project-membership (task 166/152). An agent can finally join many projects: membership routes, per-membership role and optional brain override, chat resolving context from the membership, and CLI attach-agent / detach-agent / get memberships. The legacy Agent.projectId fallback is kept for this release as the schema comment promises. Conflict resolved in main.ts: that branch added its RBAC case to mapUrlToPermission inline, while this branch had extracted the function to middleware/url-permission.ts so it could be tested. Kept the extraction and ported the case into it — joining a team is `edit:agents:<name>`, not `create:agents`, which is the authority to mint a whole agent. Also fixes something the extraction makes possible. security.test.ts contained a hand-copied reproduction of mapUrlToPermission, because main.ts self-invokes main() and nothing in it was importable. A security test asserting against a copy stops testing the system the moment the real one changes, and this copy had already drifted. It now imports the real function; all 18 assertions still pass, against the code that actually runs. Local: build clean, workspace 2550 passed, lint unchanged at 794 errors. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N4wNHWf7xSwnZCWpJcyv9p
52 lines
1.3 KiB
Markdown
52 lines
1.3 KiB
Markdown
# Task ID: 62
|
|
|
|
**Title:** Update CLI edit project command for gated field
|
|
|
|
**Status:** done
|
|
|
|
**Dependencies:** 39 ✓
|
|
|
|
**Priority:** medium
|
|
|
|
**Description:** Extend mcpctl edit project to allow editing the gated boolean field.
|
|
|
|
**Details:**
|
|
|
|
1. Update `/src/cli/src/commands/edit.ts` for project:
|
|
```typescript
|
|
async function editProject(name: string) {
|
|
const project = await api.get(`/api/v1/projects/${name}`);
|
|
|
|
// Add gated to editable fields
|
|
const yaml = `
|
|
name: ${project.name}
|
|
description: ${project.description}
|
|
gated: ${project.gated}
|
|
llmProvider: ${project.llmProvider || ''}
|
|
...`;
|
|
|
|
const edited = await openEditor(yaml);
|
|
const parsed = YAML.parse(edited);
|
|
|
|
// Validate gated is boolean
|
|
if (typeof parsed.gated !== 'boolean') {
|
|
console.error('gated must be true or false');
|
|
process.exit(1);
|
|
}
|
|
|
|
await api.put(`/api/v1/projects/${name}`, parsed);
|
|
}
|
|
```
|
|
|
|
2. Update project validation schema to accept gated
|
|
|
|
3. Handle conversion from string 'true'/'false' to boolean
|
|
|
|
**Test Strategy:**
|
|
|
|
- Unit test: Gated field appears in editor YAML
|
|
- Unit test: Gated field saved on edit
|
|
- Unit test: Boolean validation (true/false only)
|
|
- Unit test: String 'true'/'false' converted to boolean
|
|
- Integration test: End-to-end edit project gated
|