a869f77070
Merges feat/agent-project-membership (task 166/152). An agent can finally join many projects: membership routes, per-membership role and optional brain override, chat resolving context from the membership, and CLI attach-agent / detach-agent / get memberships. The legacy Agent.projectId fallback is kept for this release as the schema comment promises. Conflict resolved in main.ts: that branch added its RBAC case to mapUrlToPermission inline, while this branch had extracted the function to middleware/url-permission.ts so it could be tested. Kept the extraction and ported the case into it — joining a team is `edit:agents:<name>`, not `create:agents`, which is the authority to mint a whole agent. Also fixes something the extraction makes possible. security.test.ts contained a hand-copied reproduction of mapUrlToPermission, because main.ts self-invokes main() and nothing in it was importable. A security test asserting against a copy stops testing the system the moment the real one changes, and this copy had already drifted. It now imports the real function; all 18 assertions still pass, against the code that actually runs. Local: build clean, workspace 2550 passed, lint unchanged at 794 errors. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N4wNHWf7xSwnZCWpJcyv9p
71 lines
1.9 KiB
Markdown
71 lines
1.9 KiB
Markdown
# Task ID: 107
|
|
|
|
**Title:** Implement Edit Mode for Model Studio
|
|
|
|
**Status:** done
|
|
|
|
**Dependencies:** 106 ✓
|
|
|
|
**Priority:** medium
|
|
|
|
**Description:** Add inline editing capability to model studio for modifying paused responses before release.
|
|
|
|
**Details:**
|
|
|
|
Extend `src/cli/src/commands/console/model-studio.tsx`:
|
|
|
|
```typescript
|
|
import { spawn } from 'child_process';
|
|
import { writeFileSync, readFileSync, unlinkSync } from 'fs';
|
|
import { tmpdir } from 'os';
|
|
import { join } from 'path';
|
|
|
|
async function editContent(original: string): Promise<string> {
|
|
const editor = process.env.EDITOR ?? 'vim';
|
|
const tmpFile = join(tmpdir(), `mcpctl-edit-${Date.now()}.txt`);
|
|
|
|
writeFileSync(tmpFile, original);
|
|
|
|
return new Promise((resolve, reject) => {
|
|
const proc = spawn(editor, [tmpFile], {
|
|
stdio: 'inherit',
|
|
});
|
|
|
|
proc.on('close', (code) => {
|
|
if (code === 0) {
|
|
const edited = readFileSync(tmpFile, 'utf-8');
|
|
unlinkSync(tmpFile);
|
|
resolve(edited);
|
|
} else {
|
|
unlinkSync(tmpFile);
|
|
reject(new Error(`Editor exited with code ${code}`));
|
|
}
|
|
});
|
|
});
|
|
}
|
|
|
|
// In the TUI component:
|
|
useInput(async (input, key) => {
|
|
if (input === 'e' && pauseMode && selectedPausedItem) {
|
|
const edited = await editContent(selectedPausedItem.transformed);
|
|
pauseQueue.editAndRelease(selectedPausedItem.id, edited);
|
|
|
|
// Emit correction event
|
|
trafficCapture.emit({
|
|
eventType: 'content_edited',
|
|
sessionId: selectedPausedItem.sessionId,
|
|
contentType: selectedPausedItem.contentType,
|
|
sourceName: selectedPausedItem.sourceName,
|
|
original: selectedPausedItem.original,
|
|
transformed: selectedPausedItem.transformed,
|
|
edited,
|
|
timestamp: Date.now(),
|
|
});
|
|
}
|
|
});
|
|
```
|
|
|
|
**Test Strategy:**
|
|
|
|
Integration test: pressing 'e' opens editor with content, saving and closing applies edit, edit event is emitted with correct before/after content.
|