a869f77070
Merges feat/agent-project-membership (task 166/152). An agent can finally join many projects: membership routes, per-membership role and optional brain override, chat resolving context from the membership, and CLI attach-agent / detach-agent / get memberships. The legacy Agent.projectId fallback is kept for this release as the schema comment promises. Conflict resolved in main.ts: that branch added its RBAC case to mapUrlToPermission inline, while this branch had extracted the function to middleware/url-permission.ts so it could be tested. Kept the extraction and ported the case into it — joining a team is `edit:agents:<name>`, not `create:agents`, which is the authority to mint a whole agent. Also fixes something the extraction makes possible. security.test.ts contained a hand-copied reproduction of mapUrlToPermission, because main.ts self-invokes main() and nothing in it was importable. A security test asserting against a copy stops testing the system the moment the real one changes, and this copy had already drifted. It now imports the real function; all 18 assertions still pass, against the code that actually runs. Local: build clean, workspace 2550 passed, lint unchanged at 794 errors. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N4wNHWf7xSwnZCWpJcyv9p
43 lines
1.4 KiB
Markdown
43 lines
1.4 KiB
Markdown
# Task ID: 41
|
|
|
|
**Title:** Update PromptRequest API to handle priority
|
|
|
|
**Status:** done
|
|
|
|
**Dependencies:** 38 ✓
|
|
|
|
**Priority:** high
|
|
|
|
**Description:** Modify prompt request API endpoints to accept, validate, and return the priority field for proposed prompts.
|
|
|
|
**Details:**
|
|
|
|
1. Update validation in `/src/mcpd/src/validation/prompt.schema.ts`:
|
|
```typescript
|
|
export const CreatePromptRequestSchema = z.object({
|
|
name: z.string().min(1).max(100).regex(/^[a-z0-9-]+$/),
|
|
content: z.string().min(1).max(50000),
|
|
projectId: z.string().optional(),
|
|
createdBySession: z.string().optional(),
|
|
createdByUserId: z.string().optional(),
|
|
priority: z.number().int().min(1).max(10).default(5).optional(),
|
|
});
|
|
```
|
|
|
|
2. Update `/src/mcpd/src/routes/prompts.ts` for PromptRequest endpoints:
|
|
- POST /api/v1/promptrequests: Accept priority
|
|
- GET /api/v1/promptrequests: Return priority
|
|
- POST /api/v1/promptrequests/:id/approve: Preserve priority when creating Prompt
|
|
|
|
3. Update PromptService.approve() to copy priority from request to prompt
|
|
|
|
4. Update repository layer
|
|
|
|
**Test Strategy:**
|
|
|
|
- Unit test: POST /api/v1/promptrequests with priority creates request with correct priority
|
|
- Unit test: POST /api/v1/promptrequests uses default priority 5 when not specified
|
|
- Unit test: GET /api/v1/promptrequests returns priority field
|
|
- Unit test: Approve preserves priority from request to created prompt
|
|
- Unit test: Priority validation (1-10 range)
|