fix(smoke): match the _resultId format the pipeline actually emits #130

michal · 2026-09-05T17:04:04Z

michal commented

2026-09-05 17:04:04 +00:00

The drill-down smoke checks matched /_resultId:\s*(\S+)/ — the legacy paginator's JSON spelling. The content pipeline emits _resultId="pm-abc", so the regex never matched:

Has _resultId for drill-down printed a false ✗ on every release run (non-fatal, so it scrolled past in a green suite).
The drill-down tests that reused the regex to extract an id bailed out as "not large enough for section-split" — silently testing nothing.

A shared extractResultId() in the smoke harness now accepts either spelling and returns the bare id, so the ad-hoc replace(/[^a-zA-Z0-9-]/g, '') on the captured group is gone too.

Verified live: proxy-pipeline + prompt-drilldown now report 21/21 checks passed (was 20 with a phantom failure), 16 tests green.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JQr5Z9gYrqBQXTGBBuemZ2

The drill-down smoke checks matched `/_resultId:\s*(\S+)/` — the legacy paginator's JSON spelling. The content pipeline emits `_resultId="pm-abc"`, so the regex never matched: - `Has _resultId for drill-down` printed a false ✗ on every release run (non-fatal, so it scrolled past in a green suite). - The drill-down tests that reused the regex to extract an id bailed out as "not large enough for section-split" — silently testing nothing. A shared `extractResultId()` in the smoke harness now accepts either spelling and returns the bare id, so the ad-hoc `replace(/[^a-zA-Z0-9-]/g, '')` on the captured group is gone too. Verified live: `proxy-pipeline` + `prompt-drilldown` now report **21/21 checks passed** (was 20 with a phantom failure), 16 tests green. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01JQr5Z9gYrqBQXTGBBuemZ2

michal added 1 commit 2026-09-05 17:04:05 +00:00

fix(smoke): match the _resultId format the pipeline actually emits

CI/CD / typecheck (pull_request) Successful in 1m23s

Details

CI/CD / lint (pull_request) Successful in 2m19s

Details

CI/CD / test (pull_request) Successful in 1m41s

Details

CI/CD / smoke (pull_request) Failing after 2m6s

Details

CI/CD / build (pull_request) Successful in 2m22s

Details

CI/CD / publish (pull_request) Has been skipped

Details

22d8e13390

The drill-down checks matched /_resultId:\s*(\S+)/ — the legacy paginator's
JSON spelling. The content pipeline writes _resultId="pm-abc", so the regex
found nothing: "Has _resultId for drill-down" reported a false failure on
every run, and the drill-down tests that used the same regex to extract an id
skipped themselves as "not large enough for section-split". Both were
invisible in a green suite.

One shared extractResultId() in the smoke harness now accepts either
spelling and returns the bare id, so the ad-hoc character strip on the
captured group goes away too. proxy-pipeline's check block reports 21/21
instead of 20 with a phantom failure.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JQr5Z9gYrqBQXTGBBuemZ2

michal merged commit ad00e49262 into main

2026-09-05 17:04:10 +00:00

michal referenced this issue from a commit

2026-09-05 17:04:12 +00:00

Merge pull request #130: smoke _resultId regex

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: michal/mcpctl#130