fix(migration): the backup has no WAN by design; stop failing it for that
The cutover succeeded on vyos001 -- gateway live, bond0.53 holding 87.192.101.48 with the cloned MAC, kea serving, clients routing out through NAT. vyos002 then ran the same script and was judged unhealthy, because the mandatory checks are "default route exists / internet reachable / DNS resolves" and the backup deliberately holds its WAN interfaces DOWN. Its config was correct; the check did not apply to it. Confirmed by hand before the timer could revert a good config. This is the third instance of one mistake: asserting a condition that is not true of the box being checked. First requiring every WAN when one suffices, now requiring a WAN on the box that is configured not to have one. A delta containing `interfaces ... disable` for the WAN now identifies the backup, and the WAN-dependent checks are skipped with a note. kea and the DNS forwarder remain mandatory on both -- those are what the backup must actually be able to do. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DMVzWZgiKW2wquf5z8S1yH
This commit is contained in:
@@ -171,7 +171,15 @@ health_checks() {
|
||||
# no PPPoE stanza is a lab/partial delta, and failing it on a missing
|
||||
# pppoe0 would make the script untestable anywhere but the live cutover.
|
||||
# Announced loudly, because a quietly skipped check is worse than no check.
|
||||
if grep -qE "^set interfaces (pppoe|bonding bond0 vif 5)" "$DELTA"; then
|
||||
# A box whose delta holds its WAN interfaces DOWN is the backup: it has no
|
||||
# route out by design, and demanding one reverts a perfectly correct config.
|
||||
# This tore down vyos002 on the first successful cutover -- vyos001 went live
|
||||
# and its backup was judged unhealthy for lacking the WAN it is deliberately
|
||||
# not carrying. Same mistake as requiring the failover line: checks that do
|
||||
# not apply to the box being checked.
|
||||
if grep -qE "^set interfaces (pppoe pppoe0|bonding bond0 vif 53) disable$" "$DELTA"; then
|
||||
say " note this box holds its WAN down (backup); skipping WAN checks"
|
||||
elif grep -qE "^set interfaces (pppoe|bonding bond0 vif 5)" "$DELTA"; then
|
||||
# What matters is that SOME WAN works, not that every WAN works.
|
||||
#
|
||||
# This reverted a cutover that had genuinely succeeded. The 10 gig line came
|
||||
|
||||
Reference in New Issue
Block a user