From b8cedd62626b933378fef4c4acba131cbcfbffc2 Mon Sep 17 00:00:00 2001 From: Michal Date: Mon, 10 Aug 2026 16:59:41 +0100 Subject: [PATCH] test(smoke): give the smoke-aws-docs fixture a readiness probe MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit health-readiness.smoke.test.ts asserts no RUNNING server lacks a healthCheck.tool. The smoke suite's own shared fixture had none, so the suite reported its own scaffolding as a fleet regression — and because the fixture is in the PROTECTED set of clean-smoke-resources.ts, it is long-lived and failed that assertion on every run. Mirrors the production aws-docs probe (same package): search_documentation with a phrase, 300s interval since the call leaves the cluster. Verified live: with this applied, "every RUNNING server has a readiness probe configured" passes. Co-Authored-By: Claude Opus 5 (1M context) Claude-Session: https://claude.ai/code/session_019wUmrfkVQR6CKcYKxENq7k --- src/mcplocal/tests/smoke/fixtures/smoke-data.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/mcplocal/tests/smoke/fixtures/smoke-data.yaml b/src/mcplocal/tests/smoke/fixtures/smoke-data.yaml index faf22e9..6a69da1 100644 --- a/src/mcplocal/tests/smoke/fixtures/smoke-data.yaml +++ b/src/mcplocal/tests/smoke/fixtures/smoke-data.yaml @@ -12,6 +12,19 @@ servers: env: - name: FASTMCP_LOG_LEVEL value: "ERROR" + # Mirrors the production `aws-docs` probe. Without it this fixture is a + # RUNNING server with no readiness probe, so it fails the very assertion in + # health-readiness.smoke.test.ts that the fixture exists to support — the + # suite reporting its own scaffolding as a fleet regression. + # `search_documentation` needs a phrase; the 300s interval matches aws-docs, + # since the call leaves the cluster. + healthCheck: + tool: search_documentation + arguments: + search_phrase: "s3 bucket" + timeoutSeconds: 20 + intervalSeconds: 300 + failureThreshold: 3 projects: - name: smoke-data -- 2.49.1