michal/mcpctl
1
0
Fork 0
Code Issues Pull Requests 7 Actions Packages Projects Releases Wiki Activity

fix(servers): persist secretDelivery and entrypoint #118

Merged
michal merged 1 commits from fix/server-repo-field-mapping into main 2026-08-20 22:41:13 +00:00
Conversation 0 Commits 1 Files Changed 2 +52
michal commented 2026-08-20 22:41:10 +00:00
Owner
Copy Link

mcpctl patch server my-grafana secretDelivery=injector printed success and changed nothing. The repository maps update/create fields explicitly one by one, so a new column silently does nothing until added there — API returns 200, CLI reports success, get -o yaml still shows the old value.

Caught by trying to migrate a real server, not by a test. Adds both fields to create and update, plus tests asserting the mapping; 3 of 4 fail against the unfixed repository, verified before keeping.

`mcpctl patch server my-grafana secretDelivery=injector` printed success and changed nothing. The repository maps update/create fields explicitly one by one, so a new column silently does nothing until added there — API returns 200, CLI reports success, `get -o yaml` still shows the old value. Caught by trying to migrate a real server, not by a test. Adds both fields to create and update, plus tests asserting the mapping; 3 of 4 fail against the unfixed repository, verified before keeping.
michal added 1 commit 2026-08-20 22:41:10 +00:00
fix(servers): persist secretDelivery and entrypoint
Some checks failed
CI/CD / lint (pull_request) Successful in 1m29s
Details
CI/CD / typecheck (pull_request) Successful in 1m18s
Details
CI/CD / test (pull_request) Successful in 1m26s
Details
CI/CD / smoke (pull_request) Failing after 1m59s
Details
CI/CD / build (pull_request) Successful in 6m42s
Details
CI/CD / publish (pull_request) Has been skipped
Details
ef9ba6fb8d 
`mcpctl patch server my-grafana secretDelivery=injector` printed
"patched server 'my-grafana'" and changed nothing. The repository maps
update/create fields explicitly, one by one, so a new column silently
does nothing until it is added there — and the silence is total: the API
returns 200, the CLI reports success, and `get -o yaml` still shows the
old value.

Caught by trying to migrate a real server, not by any test.

Adds the two fields to both create and update, plus tests that assert the
mapping directly. Those tests fail against the unfixed repository (3 of 4)
— verified before keeping them.

This class of bug will recur: the mapping is manual and nothing links a
schema column to it. The tests at least make the next omission loud for
these two fields.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018vybEitX4FykeMatKe5Xki
michal merged commit 13421008c7 into main 2026-08-20 22:41:13 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
michal
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: michal/mcpctl#118
Delete Branch "fix/server-repo-field-mapping"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?