fix(deploy): stop running the smoke suite twice and crying wolf #112

Merged

michal merged 1 commits from fix/deploy-double-smoke into main 2026-08-14 22:45:30 +00:00

Conversation 0 Commits 1 Files Changed 1 +8 -6

michal commented 2026-08-14 22:45:23 +00:00

Owner

Copy Link

deploy-k8s.sh step 7 calls release.sh — which restarts mcplocal and runs the smoke suite against the binary it just installed — and then restarted mcplocal and ran the whole suite again.

Two full suites inside a minute trips mcpd's rate limiter. The second run comes back with 429s and prints:

SMOKE TESTS FAILED — system may be unhealthy. Consider rollback

over a deploy that is fine.

Observed on the 35d506d deploy: first suite 162/162 green ("Smoke tests passed!"), second suite 6 failures all reading mcpd returned 429: Rate limit exceeded, and a clean re-run a minute later 162/162 green again.

A deploy script that recommends rolling back a healthy release is worse than one that says nothing. Now: one run, one verdict — release.sh's exit status, with the rollback recipe still printed if it genuinely fails.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JNXFvxanvM6uiFcb4Mp3xU

`deploy-k8s.sh` step 7 calls `release.sh` — which restarts mcplocal and runs the smoke suite against the binary it just installed — and then restarted mcplocal and ran the whole suite **again**. Two full suites inside a minute trips mcpd's rate limiter. The second run comes back with 429s and prints: ``` SMOKE TESTS FAILED — system may be unhealthy. Consider rollback ``` over a deploy that is fine. Observed on the `35d506d` deploy: first suite 162/162 green ("Smoke tests passed!"), second suite 6 failures all reading `mcpd returned 429: Rate limit exceeded`, and a clean re-run a minute later 162/162 green again. A deploy script that recommends rolling back a healthy release is worse than one that says nothing. Now: one run, one verdict — `release.sh`'s exit status, with the rollback recipe still printed if it genuinely fails. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01JNXFvxanvM6uiFcb4Mp3xU

michal added 1 commit 2026-08-14 22:45:24 +00:00

fix(deploy): stop running the smoke suite twice and crying wolf ... 21aadf6d82

Step 7 called release.sh — which restarts mcplocal and runs the smoke suite
against the binary it just installed — and then restarted mcplocal and ran the
whole suite again. Two full suites inside a minute trips mcpd's rate limiter,
so the second run came back with six 429s and printed

    SMOKE TESTS FAILED — system may be unhealthy. Consider rollback

over a deploy that was fine. Seen for real on 35d506d: the first suite was
162/162 green, the second failed only on `mcpd returned 429: Rate limit
exceeded`, and a clean re-run afterwards was 162/162 again.

A deploy script that recommends rolling back a healthy release is worse than
one that says nothing. One run, one verdict — release.sh's exit status.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JNXFvxanvM6uiFcb4Mp3xU

michal merged commit b6983f036d into main 2026-08-14 22:45:30 +00:00

michal referenced this issue from a commit 2026-08-14 22:45:32 +00:00

merge: stop the deploy script running smoke twice (#112)

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

michal

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: michal/mcpctl#112