diff --git a/src/mcpd/src/services/server-identity.service.ts b/src/mcpd/src/services/server-identity.service.ts index 50b154b..5581e04 100644 --- a/src/mcpd/src/services/server-identity.service.ts +++ b/src/mcpd/src/services/server-identity.service.ts @@ -135,17 +135,29 @@ export class ServerIdentityService { const secretNames = this.secretNamesFor(server); if (secretNames.length === 0) return undefined; - // mcpd owns the runner images, so their entrypoints are known. A - // dockerImage server's is not introspectable — hence `entrypoint` being - // required on the row at validation time. - const imageEntrypoint = server.packageName - ? server.runtime === 'python' - ? ['uvx'] - : ['npx', '-y'] - : ((server.entrypoint as string[] | null) ?? undefined); - if (imageEntrypoint === undefined || imageEntrypoint.length === 0) return undefined; + // Build the COMPLETE argv the container should run. It differs by shape: + // + // package server — mcpd owns the runner image, whose ENTRYPOINT + // (`npx -y` / `uvx`) is lost once we take over + // `command`, so it must be prepended here. + // image + command — `command` is already a full command line; mcpd would + // have run exactly it. Prepending anything breaks it. + // image only — the image's own ENTRYPOINT would run and mcpd cannot + // introspect it, so the row must declare `entrypoint`. + // + // Getting this wrong returns undefined and SILENTLY skips the wrapper: the + // agent still renders the file, nothing sources it, and the server starts + // with empty credentials. Observed on docmost and my-home-assistant, which + // carry a `command` but no `entrypoint`. + const hasPackage = server.packageName !== null && server.packageName !== undefined && server.packageName !== ''; + const argv = hasPackage + ? [...(server.runtime === 'python' ? ['uvx'] : ['npx', '-y']), ...(command ?? [server.packageName as string])] + : command !== undefined && command.length > 0 + ? command + : ((server.entrypoint as string[] | null) ?? undefined); - return wrapCommandForInjector([...imageEntrypoint, ...(command ?? [])], secretNames); + if (argv === undefined || argv.length === 0) return undefined; + return wrapCommandForInjector(argv, secretNames); } /** diff --git a/src/mcpd/tests/injector-argv.test.ts b/src/mcpd/tests/injector-argv.test.ts new file mode 100644 index 0000000..bcc74be --- /dev/null +++ b/src/mcpd/tests/injector-argv.test.ts @@ -0,0 +1,58 @@ +/** + * Which argv the injector wrapper wraps, by server shape. + * + * Getting this wrong is SILENT: wrapCommand returns undefined, the wrapper is + * skipped, the agent still renders /vault/secrets/, nothing sources it, + * and the server starts with empty credentials. Observed live on docmost and + * my-home-assistant, which carry a `command` but no `entrypoint`. + */ +import { describe, it, expect } from 'vitest'; +import { ServerIdentityService } from '../src/services/server-identity.service.js'; +import type { SecretBackendService } from '../src/services/secret-backend.service.js'; + +const svc = new ServerIdentityService( + {} as unknown as SecretBackendService, + { namespace: 'mcpctl-servers', ensure: async () => undefined, remove: async () => undefined }, +); + +const withSecret = { env: [{ name: 'T', valueFrom: { secretRef: { name: 'creds', key: 'K' } } }] }; +/** The wrapper is `sh -c