merge: AgentProject membership — the junction is now load-bearing
Merges feat/agent-project-membership (task 166/152). An agent can finally join many projects: membership routes, per-membership role and optional brain override, chat resolving context from the membership, and CLI attach-agent / detach-agent / get memberships. The legacy Agent.projectId fallback is kept for this release as the schema comment promises. Conflict resolved in main.ts: that branch added its RBAC case to mapUrlToPermission inline, while this branch had extracted the function to middleware/url-permission.ts so it could be tested. Kept the extraction and ported the case into it — joining a team is `edit:agents:<name>`, not `create:agents`, which is the authority to mint a whole agent. Also fixes something the extraction makes possible. security.test.ts contained a hand-copied reproduction of mapUrlToPermission, because main.ts self-invokes main() and nothing in it was importable. A security test asserting against a copy stops testing the system the moment the real one changes, and this copy had already drifted. It now imports the real function; all 18 assertions still pass, against the code that actually runs. Local: build clean, workspace 2550 passed, lint unchanged at 794 errors. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N4wNHWf7xSwnZCWpJcyv9p
This commit is contained in:
24
.taskmaster/tasks/task_129.md
Normal file
24
.taskmaster/tasks/task_129.md
Normal file
@@ -0,0 +1,24 @@
|
||||
# Task ID: 129
|
||||
|
||||
**Title:** Task repository with compare-and-swap transitions
|
||||
|
||||
**Status:** pending
|
||||
|
||||
**Dependencies:** 118
|
||||
|
||||
**Priority:** medium
|
||||
|
||||
**Description:** Create TaskRepository with optimistic locking state transitions using updateMany with where clause
|
||||
|
||||
**Details:**
|
||||
|
||||
Create src/mcpd/src/repositories/task.repository.ts:
|
||||
1. Standard CRUD methods following existing patterns
|
||||
2. transition(id, fromState, toState): use prisma.task.updateMany({ where: { id, state: fromState }, data: { state: toState, version: { increment: 1 } } }), return affected count
|
||||
3. If affected count is 0, the transition failed (race or wrong state)
|
||||
4. findByFilters(): support epicTaskId, state, assigneeId filters
|
||||
5. Include verdict and event relations where appropriate
|
||||
|
||||
**Test Strategy:**
|
||||
|
||||
Unit tests: test transition succeeds when state matches, test transition returns 0 when state doesn't match (simulating race), test concurrent transitions only one wins.
|
||||
Reference in New Issue
Block a user