merge: AgentProject membership — the junction is now load-bearing
Merges feat/agent-project-membership (task 166/152). An agent can finally join many projects: membership routes, per-membership role and optional brain override, chat resolving context from the membership, and CLI attach-agent / detach-agent / get memberships. The legacy Agent.projectId fallback is kept for this release as the schema comment promises. Conflict resolved in main.ts: that branch added its RBAC case to mapUrlToPermission inline, while this branch had extracted the function to middleware/url-permission.ts so it could be tested. Kept the extraction and ported the case into it — joining a team is `edit:agents:<name>`, not `create:agents`, which is the authority to mint a whole agent. Also fixes something the extraction makes possible. security.test.ts contained a hand-copied reproduction of mapUrlToPermission, because main.ts self-invokes main() and nothing in it was importable. A security test asserting against a copy stops testing the system the moment the real one changes, and this copy had already drifted. It now imports the real function; all 18 assertions still pass, against the code that actually runs. Local: build clean, workspace 2550 passed, lint unchanged at 794 errors. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N4wNHWf7xSwnZCWpJcyv9p
This commit is contained in:
59
.taskmaster/tasks/task_069.md
Normal file
59
.taskmaster/tasks/task_069.md
Normal file
@@ -0,0 +1,59 @@
|
||||
# Task ID: 69
|
||||
|
||||
**Title:** Add CLI unit tests for new prompt and project flags
|
||||
|
||||
**Status:** done
|
||||
|
||||
**Dependencies:** 59 ✓, 60 ✓, 61 ✓, 62 ✓
|
||||
|
||||
**Priority:** medium
|
||||
|
||||
**Description:** Create unit tests for the new CLI flags: --priority, --link for prompts, -A for get, and gated field for projects.
|
||||
|
||||
**Details:**
|
||||
|
||||
1. Add tests in `/src/cli/tests/commands/prompt.test.ts`:
|
||||
```typescript
|
||||
describe('create prompt command', () => {
|
||||
it('--priority sets prompt priority', async () => {
|
||||
await cli('create prompt test --priority 8');
|
||||
expect(mockApi.post).toHaveBeenCalledWith(
|
||||
'/api/v1/prompts',
|
||||
expect.objectContaining({ priority: 8 })
|
||||
);
|
||||
});
|
||||
|
||||
it('--priority validates range 1-10', async () => {
|
||||
await expect(cli('create prompt test --priority 15'))
|
||||
.rejects.toThrow('Priority must be between 1 and 10');
|
||||
});
|
||||
|
||||
it('--link sets linkTarget', async () => {
|
||||
await cli('create prompt test --link proj/srv:uri');
|
||||
expect(mockApi.post).toHaveBeenCalledWith(
|
||||
'/api/v1/prompts',
|
||||
expect.objectContaining({ linkTarget: 'proj/srv:uri' })
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('get prompt command', () => {
|
||||
it('-A shows all projects', async () => {
|
||||
await cli('get prompt -A');
|
||||
expect(mockApi.get).toHaveBeenCalledWith('/api/v1/prompts?all=true');
|
||||
});
|
||||
});
|
||||
```
|
||||
|
||||
2. Add tests for project gated field editing
|
||||
|
||||
3. Add tests for describe project output
|
||||
|
||||
**Test Strategy:**
|
||||
|
||||
This task IS the test implementation. Verify:
|
||||
- Flag parsing tests pass
|
||||
- Validation tests cover edge cases
|
||||
- API call tests verify correct parameters
|
||||
- Output formatting tests verify columns
|
||||
- Tests mock API properly
|
||||
Reference in New Issue
Block a user