feat(mcpd): make AgentProject real — an agent joins many projects
The AgentProject junction has existed since the data-model commit and nothing
read it. `grep -c agentProject src/mcpd/src/services/chat.service.ts` returned
0; chat resolved an agent's project from the legacy single `Agent.projectId`
scalar. So the schema claimed "an agent is a person who joins zero, one, or
many projects" (docs/agentic-teams.md §4) while the running system still gave
every agent exactly one project. A schema that lies about behaviour is worse
than a missing feature: it reads as done, so nobody builds it.
This makes the junction load-bearing.
Membership is now a real surface (task 152):
GET /api/v1/agents/:name/projects memberships
POST /api/v1/agents/:name/projects/:project join, body {role?, llm?}
DELETE /api/v1/agents/:name/projects/:project leave
GET /api/v1/projects/:name/memberships the roster, with roles
`role` is TEXT (developer|qa|security|sre in v1) and is validated in the
service layer, not the database — production provisions with `prisma db push`,
so a CHECK constraint written into a migration would never run there. Adding a
fifth role stays a one-line change.
RBAC: joining/leaving is `edit:agents:<name>`, not the `create:agents` the
default method→action mapping would have produced. Minting a whole new agent
and adding an existing one to a team are not the same authority; this mirrors
project↔server attach/detach already being `edit:projects`. Reading a roster is
`view:` on the side you asked from.
Chat honours it. `prepareContext` resolves the project from the membership when
the caller names one, and the resolution runs *before* the Llm lookup so a
per-membership `llmId` can replace the agent's pinned brain — and therefore its
whole failover pool — rather than patching the dispatch list afterwards. That
override is why the brain-ownership question (§15 Q1) can still go either way
without a migration: today the answer is per membership.
Naming a project the agent has not joined is an error that names the fix, not a
silent fallback. Answering from a *different* project's tools and prompts than
the one asked for is the failure mode worth being loud about.
The legacy scalar keeps working this release, as the schema comment promises:
`--project` accepts a membership *or* a legacy pin naming that same project,
bare `mcpctl chat <agent>` is unchanged, and `GET /projects/:p/agents` returns
the union of members and legacy-pinned agents so nothing disappears from a
project mid-migration (mcplocal's agents plugin reads that endpoint).
CLI: `mcpctl chat <agent> --project <p>` (previously rejected as "not both"),
plus `attach-agent` / `detach-agent` alongside the existing attach-server pair,
`get agents --project`, and `get memberships` with ROLE and BRAIN columns.
Completions come from the generator, not hand-edits.
Threads stay scoped to the agent, not to (agent, project) — §4 wants the
latter, but that needs a schema change and a story for what happens to those
threads when a membership is revoked. Deliberately not decided here.
Tests: 51 new (43 mcpd, 8 CLI). Full suite 2514 pass. Lint unchanged at
794 errors / 77 warnings.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
30
docs/chat.md
30
docs/chat.md
@@ -8,6 +8,7 @@ create one.
|
||||
|
||||
```bash
|
||||
mcpctl chat <agent> # interactive REPL, new thread
|
||||
mcpctl chat <agent> --project <p> # same agent, viewing project p
|
||||
mcpctl chat <agent> --thread <id> # interactive REPL, resume thread
|
||||
mcpctl chat <agent> -m "hi" # one-shot, prints reply, no REPL
|
||||
mcpctl chat <agent> -m "hi" --no-stream # one-shot, single JSON response (no SSE)
|
||||
@@ -17,6 +18,35 @@ Streaming is on by default. Text deltas land on stdout as they arrive; tool
|
||||
calls and tool results print to stderr in dim brackets so the chat output
|
||||
stays clean.
|
||||
|
||||
## Two lenses on the same agent
|
||||
|
||||
`mcpctl chat alice` is the person **on their own** — their system prompt, their
|
||||
own pinned brain, no project tools.
|
||||
|
||||
`mcpctl chat alice --project sre` is the **same person viewing one of their
|
||||
teams**: the project's Prompts join the system block, the project's MCP servers
|
||||
become callable tools, and if that membership carries a brain override, that
|
||||
Llm answers instead of alice's pinned one.
|
||||
|
||||
```bash
|
||||
mcpctl attach-agent alice --project sre --role sre # join first
|
||||
mcpctl chat alice --project sre
|
||||
```
|
||||
|
||||
The agent must actually be a member. Naming a project it has not joined is an
|
||||
error naming the fix, not a silent fallback to some other project's context:
|
||||
|
||||
```
|
||||
Agent 'alice' is not a member of project 'payments'.
|
||||
Join it with: mcpctl attach-agent alice --project payments
|
||||
```
|
||||
|
||||
(The legacy single-project pin on the agent still counts as membership in that
|
||||
one project for this release — see [agents.md](agents.md#team-membership-an-agent-joins-many-projects).)
|
||||
|
||||
Threads stay scoped to the **agent**, not to (agent, project) — switching
|
||||
`--project` mid-conversation changes the context layer, not the history.
|
||||
|
||||
## Project chat
|
||||
|
||||
Chat directly with a **project** — no Agent needed. The session sees the
|
||||
|
||||
Reference in New Issue
Block a user