64 lines
2.1 KiB
Markdown
64 lines
2.1 KiB
Markdown
|
# Task ID: 65
|
||
|
|
|
||
|
|
**Title:** Add unit tests for gating state machine
|
||
|
|
|
||
|
|
**Status:** done
|
||
|
|
|
||
|
|
**Dependencies:** 50 ✓, 52 ✓
|
||
|
|
|
||
|
|
**Priority:** high
|
||
|
|
|
||
|
|
**Description:** Create comprehensive unit tests for the session gating state machine covering all transitions and edge cases.
|
||
|
|
|
||
|
|
**Details:**
|
||
|
|
|
||
|
|
1. Add tests in `/src/mcplocal/tests/router-gating.test.ts`:
|
||
|
|
```typescript
|
||
|
|
describe('Gating State Machine', () => {
|
||
|
|
describe('initial state', () => {
|
||
|
|
it('starts gated for gated project', () => {
|
||
|
|
const router = createRouter({ gated: true });
|
||
|
|
const state = router.getSessionState('session1');
|
||
|
|
expect(state.gated).toBe(true);
|
||
|
|
});
|
||
|
|
|
||
|
|
it('starts ungated for non-gated project', () => {
|
||
|
|
const router = createRouter({ gated: false });
|
||
|
|
const state = router.getSessionState('session1');
|
||
|
|
expect(state.gated).toBe(false);
|
||
|
|
});
|
||
|
|
});
|
||
|
|
|
||
|
|
describe('begin_session transition', () => {
|
||
|
|
it('ungates session on successful begin_session', async () => {
|
||
|
|
const router = createGatedRouter();
|
||
|
|
await router.handleBeginSession('session1', { tags: ['test'] });
|
||
|
|
expect(router.getSessionState('session1').gated).toBe(false);
|
||
|
|
});
|
||
|
|
|
||
|
|
it('returns matched prompts', async () => { ... });
|
||
|
|
it('sends notifications/tools/list_changed', async () => { ... });
|
||
|
|
});
|
||
|
|
|
||
|
|
describe('intercept transition', () => {
|
||
|
|
it('ungates session on tool call intercept', async () => { ... });
|
||
|
|
it('extracts keywords from tool call', async () => { ... });
|
||
|
|
it('injects briefing with tool result', async () => { ... });
|
||
|
|
});
|
||
|
|
|
||
|
|
describe('tools/list behavior', () => {
|
||
|
|
it('returns only begin_session while gated', async () => { ... });
|
||
|
|
it('returns all tools + read_prompts after ungating', async () => { ... });
|
||
|
|
});
|
||
|
|
});
|
||
|
|
```
|
||
|
|
|
||
|
|
**Test Strategy:**
|
||
|
|
|
||
|
|
This task IS the test implementation. Verify:
|
||
|
|
- Initial state tests pass
|
||
|
|
- Transition tests cover happy paths
|
||
|
|
- Edge case tests (already ungated, etc.)
|
||
|
|
- Notification tests verify signals sent
|
||
|
|
- Tests use proper mocking
|