From 420f37189712571aa3d84ba8cc3f5bac734707fd Mon Sep 17 00:00:00 2001
From: Michal Rydlikowski <michal@itaz.eu>
Date: Fri, 13 Mar 2026 23:34:59 +0000
Subject: [PATCH] fix: remove instance wait loop from CI smoke tests

Server instances require Docker/Podman (mcpd starts them as containers).
CI has no container runtime, so instances will never reach RUNNING.
Tests requiring running instances are already excluded.

Replace the 5-minute wait loop with a quick fixture verification step
that confirms servers, projects, and prompts were applied correctly,
and reports instance status for informational purposes only.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .gitea/workflows/ci.yml | 42 ++++++++++++++++++++++-------------------
 1 file changed, 23 insertions(+), 19 deletions(-)

diff --git a/.gitea/workflows/ci.yml b/.gitea/workflows/ci.yml
index 2b15d72..d8f79b8 100644
--- a/.gitea/workflows/ci.yml
+++ b/.gitea/workflows/ci.yml
@@ -216,28 +216,32 @@ jobs:
       - name: Apply smoke test fixtures
         run: mcpctl apply -f src/mcplocal/tests/smoke/fixtures/smoke-data.yaml
 
-      - name: Wait for server instance
+      - name: Verify fixture applied
         run: |
-          echo "Waiting for smoke-aws-docs instance..."
-          for i in $(seq 1 10); do
-            STATUS=$(mcpctl get instances -o json 2>/dev/null | \
-              node -e "try{const d=JSON.parse(require('fs').readFileSync('/dev/stdin','utf-8'));const i=Array.isArray(d)?d.find(x=>x.serverName&&x.serverName.includes('aws')):null;console.log(i?.status??'WAITING')}catch{console.log('WAITING')}" 2>/dev/null || echo "WAITING")
-            echo "  Instance status: $STATUS ($i/10)"
-            if [ "$STATUS" = "RUNNING" ]; then
-              echo "Instance is running!"
-              break
-            fi
-            if [ "$i" = "10" ]; then
-              echo "::warning::Instance did not reach RUNNING — container management may not be available in CI"
-              echo "API-layer smoke tests will still run"
-            fi
-            sleep 2
-          done
+          echo "==> Checking applied fixtures..."
+          mcpctl get servers -o json | node -e "
+            const d=JSON.parse(require('fs').readFileSync('/dev/stdin','utf-8'));
+            console.log('Servers:', Array.isArray(d) ? d.map(s=>s.name).join(', ') : 'none');
+          "
+          mcpctl get projects -o json | node -e "
+            const d=JSON.parse(require('fs').readFileSync('/dev/stdin','utf-8'));
+            console.log('Projects:', Array.isArray(d) ? d.map(p=>p.name).join(', ') : 'none');
+          "
+          # Server instances require Docker/Podman (container orchestrator).
+          # CI has no container runtime, so instances will stay in PENDING.
+          # Tests that need running instances are excluded below.
+          echo "==> Instance status (informational — no container runtime in CI):"
+          mcpctl get instances -o json 2>/dev/null | node -e "
+            const d=JSON.parse(require('fs').readFileSync('/dev/stdin','utf-8'));
+            if (Array.isArray(d)) d.forEach(i => console.log('  ' + (i.serverName||i.name) + ': ' + i.status));
+            else console.log('  (none)');
+          " || echo "  (no instances)"
 
       - name: Run smoke tests
-        # Exclude tests that need a running MCP server instance (Docker) or
-        # LLM providers — CI has neither.  --no-file-parallelism avoids
-        # concurrent requests crashing mcplocal.
+        # Server instances need Docker/Podman to start (container-based MCP
+        # servers). CI has no container runtime, so exclude tests that
+        # require a running server instance or LLM providers.
+        # --no-file-parallelism avoids concurrent requests crashing mcplocal.
         run: >-
           pnpm --filter mcplocal exec vitest run
           --config vitest.smoke.config.ts